Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Setup.swift file when running the init command #283

Merged
merged 3 commits into from Mar 13, 2019

Conversation

pepicrft
Copy link
Contributor

Short description 馃摑

Create a Setup.swift file when running the tuist init command. The Setup.swift doesn't contain any up command is intended to work as a reference for developers to know that it exists and how they can use it.

Solution 馃摝

  • Add a new private method to the init command that generates the file.
  • Add tests.

@pepicrft pepicrft self-assigned this Mar 12, 2019
@pepicrft pepicrft requested a review from a team March 12, 2019 18:08
@tuistbot
Copy link
Contributor

1 Warning
鈿狅笍 Have you introduced any user-facing changes? If so, please take some time to update the documentation. Keeping the documentation up to date makes it easier for users to learn how to use Tuist.

Generated by 馃毇 Danger

@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #283 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
+ Coverage   87.96%   87.97%   +<.01%     
==========================================
  Files         265      262       -3     
  Lines        9405     9319      -86     
==========================================
- Hits         8273     8198      -75     
+ Misses       1132     1121      -11
Impacted Files Coverage 螖
...ests/TuistKitTests/Commands/InitCommandTests.swift 100% <100%> (酶) 猬嗭笍
Sources/TuistKit/Commands/InitCommand.swift 96.24% <100%> (+0.14%) 猬嗭笍
Sources/TuistCoreTesting/Utils/MockSystem.swift 69.44% <0%> (-5.56%) 猬囷笍
Sources/ProjectDescription/Up/UpCustom.swift
...s/TuistKitTests/Models/Up/UpHomebrewTapTests.swift
Sources/TuistKit/Models/Up/UpHomebrewTap.swift
...ests/TuistKitTests/Models/Up/UpHomebrewTests.swift
Sources/TuistKit/Models/Up/UpHomebrew.swift
Tests/TuistKitTests/Models/Up/UpCustomTests.swift
Sources/ProjectDescription/Up/UpCarthage.swift
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9f53f22...6e01538. Read the comment docs.

Copy link
Collaborator

@ollieatkinson ollieatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃

import ProjectDescription

let setup = Setup([
// .carthage()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add a few examples but commented out.

This example when commented out wont compile will it?

@pepicrft pepicrft merged commit 39f937c into master Mar 13, 2019
@pepicrft pepicrft deleted the generate-setup branch March 13, 2019 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants