Manifest targets are now static frameworks (to avoid link errors) #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The manifest target can be built to ensure there are no syntax errors in the project manifests - This target doesn't need to be linked, a compilation step is sufficient to serve its purpose - By converting the manifest target to a static framework, the link step is skipped and the errors that were obtained during that step can be avoided all together Test Plan: - Run `tuist generate` on any fixture within `fixtures` - Open the generated workspace (you can use `tuist focus` as a shortcut to those steps) - Build the `<Project>-Manifest` scheme in Xcode - Verify no link errors appear
kwridan
changed the title
Generated by 🚫 Danger |
kwridan
commented
Mar 13, 2019
| buildSettings["SWIFT_INCLUDE_PATHS"] = frameworkParentDirectory.asString | ||
| buildSettings["SWIFT_VERSION"] = Constants.swiftVersion | ||
| buildSettings["LD"] = "/usr/bin/true" |
There was a problem hiding this comment.
I omitted these settings as they are no longer needed to get the target to compile while it's a static framework.
Codecov Report
@@ Coverage Diff @@
## master #287 +/- ##
==========================================
- Coverage 87.92% 87.91% -0.02%
==========================================
Files 268 268
Lines 9402 9393 -9
==========================================
- Hits 8267 8258 -9
Misses 1135 1135
Continue to review full report at Codecov.
|
pepicrft
approved these changes
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #286
Short description 📝
The generated manifest target (e.g. "MyProject-Manifest") is used to allow code completion on the project manifest files (
Project.swift) as well as validate the code written within it is syntacticly valid.Building this target will succeed however a few linker errors do appear as a consequence:
e.g.
Solution 📦
The link step can be skipped all together by declaring the manifest target will be staticly linked.
Implementation 👩💻👨💻
.staticFrameworkTest Plan 🛠
tuist generateon any fixture withinfixturestuist focusas a shortcut to those steps)<Project>-Manifestscheme in Xcode