New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set TEST_HOST and BUNDLE_LOADER for app unit tests #300
Conversation
Codecov Report
@@ Coverage Diff @@
## master #300 +/- ##
==========================================
- Coverage 89.25% 89.22% -0.03%
==========================================
Files 279 276 -3
Lines 10619 10501 -118
==========================================
- Hits 9478 9370 -108
+ Misses 1141 1131 -10
Continue to review full report at Codecov.
|
Generated by π« Danger |
β¦ault generated test target runs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work π - both unit and ui tests now work!
We can revisit this and consider the enum solution suggested on the original issue (option 3 in #204) once we find more use cases for product specific attributes.
set
TEST_HOST
andBUNDLE_LOADER
for Unit tests bundle for an app target so that the default generated test target runsResolves #204
Short description π
The default generated project did not set these two build configurations which meant that the app unit test target was not able to resolve the symbols stores inside of the application.
Solution π¦
By setting
TEST_HOST
andBUNDLE_LOADER
ld is able to link the symbols and run the unit tests.The implementation will look at the dependencies for the test target and the find the app to set as the test host. Currently this selects the first app, but we can expand on this in the future as and when we better understand peoples requirements.
Test Plan π©βπ»π¨βπ»
bundle exec rake features
swift test