Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensuring Library search paths and Swift import paths are set #308

Merged
merged 3 commits into from
Mar 27, 2019
Merged

Ensuring Library search paths and Swift import paths are set #308

merged 3 commits into from
Mar 27, 2019

Commits on Mar 24, 2019

  1. Ensuring Library search paths and Swift import paths are set 

    - A few additional build settings are needed when linking against pre-built static libraries
- `LIBRARY_SEARCH_PATHS` needs to point to the directory containing the `.a` file
- `SWIFT_INCLUDE_PATHS` need to point to the directory containing the `.swiftmodule` file

Test Plan:

- Generate `fixtures/ios_app_with_static_libraries`
- Verify the application builds
- Verify the `LIBRARY_SEARCH_PATHS` and `SWIFT_INCLUDE_PATHS` settings are set on target `A`
    @kwridan
    kwridan committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    3de69de View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2019

  1. Removing xcsharedate of fixture

    @kwridan
    kwridan committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    3fc9acf View commit details
    Browse the repository at this point in the history

  2. Ensuring a fat static library is used as a fixture 

    - added a `build.sh` helper script to allow re-creating the static library if needed
    @kwridan
    kwridan committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    1f64aad View commit details
    Browse the repository at this point in the history