Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ValueGraph to Graph #3083

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Rename ValueGraph to Graph #3083

merged 1 commit into from
Jun 21, 2021

Conversation

fortmarek
Copy link
Member

@fortmarek fortmarek commented Jun 20, 2021

Short description πŸ“

Since ValueGraph has been for some time the only graph, I think we can drop the Value suffix

Checklist βœ…

  • The code architecture and patterns are consistent with the rest of the codebase.
  • The changes have been tested following the documented guidelines.
  • The CHANGELOG.md has been updated to reflect the changes. In case of a breaking change, it's been flagged as such.
  • In case the PR introduces changes that affect users, the documentation has been updated.

Copy link
Collaborator

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fortmarek, this should reduce some of the confusion around the graph type πŸ˜…

@fortmarek fortmarek merged commit 77ec006 into main Jun 21, 2021
@fortmarek fortmarek deleted the value_graph_rename branch June 21, 2021 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants