Omit runPostActionsOnFailure scheme attribute when not enabled
#3087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: tuist#2991 - Xcode automatically removes the `runPostActionsOnFailure` when not enabled - This causes projects to get modified by Xcode after generation even though semantically they are equivalent (causes issues for workflows where generated issues are checked in) - To mitigate this, the `runPostActionsOnFailure` is omitted incase it's not enabled and only set when enabled Test Plan: - Generate a fixture that does't have the `runPostActionsOnFailure` option enabled e.g. ```sh swift build swift run tuist generate --path projects/tuist/fixtures/ios_app_with_tests ``` - Verify the generated schemes do not contain the `runPostActionsOnFailure` attribute - Generate a fixture that has the `runPostActionsOnFailure` option enabled ```sh swift build swift run tuist generate --path projects/tuist/fixtures/ios_app_with_custom_scheme ``` - Verify the App-debug scheme's build action has the `runPostActionsOnFailure` set
pepicrft
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2991
Short description 📝
runPostActionsOnFailurewhen not enabledrunPostActionsOnFailureis omitted incase it's not enabled and only set when enabledTest Plan 🛠
runPostActionsOnFailureoption enablede.g.
runPostActionsOnFailureattributerunPostActionsOnFailureoption enabledrunPostActionsOnFailuresetChecklist ✅
CHANGELOG.mdhas been updated to reflect the changes. In case of a breaking change, it's been flagged as such.In case the PR introduces changes that affect users, the documentation has been updated.