Added disableBundleAccessors config generation option #3088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortmarek
reviewed
Jun 21, 2021
There was a problem hiding this comment.
This is great, thanks @wojciech-kulik!
Could you also add this case to the website documentation here?
..._with_framework_and_disabled_resources/StaticFramework/Sources/StaticFrameworkResouces.swift
Outdated
Show resolved
Hide resolved
Tests/TuistKitTests/GraphMappers/ProjectMapperProviderTests.swift
Outdated
Show resolved
Hide resolved
projects/tuist/fixtures/ios_app_with_framework_and_disabled_resources/Tuist/Config.swift
Show resolved
Hide resolved
|
@all-contributors add @wojciech-kulik for code |
|
I've put up a pull request to add @wojciech-kulik! 🎉 |
fortmarek
approved these changes
Jun 21, 2021
Thanks :)! |
pepicrft
approved these changes
Jun 21, 2021
|
I think we can merge once CI is green :) |
|
is this option still available in 3.0 version? |
You can use it as Project options. ` ` |
|
How to disable autogeneration Sources? disableBundleAccessors only disable 2/6 autogenerated files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3052 and #3077
Short description 📝
Added
disableBundleAccessorsconfig generation option.Checklist ✅
CHANGELOG.mdhas been updated to reflect the changes. In case of a breaking change, it's been flagged as such.In case the PR introduces changes that affect users, the documentation has been updated.