Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check to see if contents.xcworkspacedata exists before writing #312

Merged
merged 3 commits into from Mar 30, 2019

Conversation

ollieatkinson
Copy link
Collaborator

Resolves #309

Short description 馃摑

Check for the existence of contents.xcworkspacedata before trying to write over the workspace.

Test Plan 馃И

  1. Unit test to ensure we do not throw an error in the result of a failure
  2. Generate a workspace for fixtures/ios_app_with_custom_workspace/, delete contents.xcworkspacedata and try to generate again

I did not deem it necessary to introduce another fixture test here, but if you feel like it is necessary I can go back and add one in.

@codecov
Copy link

codecov bot commented Mar 30, 2019

Codecov Report

Merging #312 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
+ Coverage   89.31%   89.32%   +0.01%     
==========================================
  Files         276      276              
  Lines       10591    10607      +16     
==========================================
+ Hits         9459     9475      +16     
  Misses       1132     1132
Impacted Files Coverage 螖
...ources/TuistKit/Generator/WorkspaceGenerator.swift 65.93% <酶> (酶) 猬嗭笍
...stKitTests/Generator/WorkspaceGeneratorTests.swift 93.69% <100%> (+1.06%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 5956b94...74ec40e. Read the comment docs.

Copy link
Collaborator

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@tuistbot
Copy link
Contributor

tuistbot commented Mar 30, 2019

1 Warning
鈿狅笍 Have you introduced any user-facing changes? If so, please take some time to update the documentation. Keeping the documentation up to date makes it easier for users to learn how to use Tuist.

Generated by 馃毇 Danger

@ollieatkinson ollieatkinson merged commit 14f99d2 into master Mar 30, 2019
@ollieatkinson ollieatkinson deleted the fix-309 branch March 30, 2019 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generation fails in the event an empty .xcworkspace directory exists
3 participants