[Dependencies.swift] Fix failed decoding for not present container key + Tests

[havebeenfitz]

Resolves #3107 (comment)

Short description 📝

Is seems like Carthage version files are not so strict, so I made the container key optional and wrote a test for this kind of case. I'm not sure if this shoud be as 1.45.2 or 1.46 and newer, please check the merge destination

Checklist ✅

• The code architecture and patterns are consistent with the rest of the codebase.
• The changes have been tested following the documented guidelines.
• The CHANGELOG.md has been updated to reflect the changes. In case of a breaking change, it's been flagged as such.
• In case the PR introduces changes that affect users, the documentation has been updated.

[pepicrft]

Thanks for contributing this one @havebeenfitz 👏🏼. Besides the tiny comment that I left, it'd be great to update the CHANGELOG.md to list your change there. After that and if CI is green, we can merge :)

[pepicrft]

@all-contributors add @havebeenfitz for bug

[allcontributors]

@pepibumur

I've put up a pull request to add @havebeenfitz! 🎉

[havebeenfitz]

So it looks like binary Carthage dependencies deliberately lack the container key. And Graph relies on that, otherwise, dependency is absent for Graph

At first I thought ok, let’s rely on name + .xcframeworkextension, but then I looked at .binary carthage dependencies and they all lack the container
So I guess ThirdPartyDependency and ThirdPartyDependency.Kind should have one more case - framework and parse accordingly

What do you think?

.GoogleMaps.version

{
  "Mac" : [
  ],
  "watchOS" : [
  ],
  "tvOS" : [
  ],
  "commitish" : "3.10.0",
  "iOS" : [
    {
      "name" : "GoogleMaps",
      "hash" : "87a19f3ade1a24cc17b9c943952326b3b237b6205265054da33350311946dc0f",
      "linking" : "dynamic"
    },
    {
      "name" : "GoogleMapsBase",
      "hash" : "19884971db68d9d66ef45134fed7890b27200153c90e69022db54e1d6549b57d",
      "linking" : "dynamic"
    },
    {
      "name" : "GoogleMapsCore",
      "hash" : "42eb96fd4a53f638f56befc6422cf6d07165d9d1e8569c934bf63a17c583a77d",
      "linking" : "dynamic"
    },
    {
      "name" : "GoogleMapsM4B",
      "hash" : "780bc4e295f5d2adba95756a10f9c0cbbd5e3908f7142ef4ce7c81745d1f9fdb",
      "linking" : "dynamic"
    }
  ]
}

[laxmorek]

I will review the rest after my working hours. :)

[laxmorek]

@havebeenfitz call ./fourier format swift --fix to satisfy formatting rules

You can read more about fourier here.

[laxmorek]

@tuist/core Do you know why CI doest fire checks for unit and acceptance tests?

[havebeenfitz]

Hey guys! I spent some time fixing this Graph and realized that it's starting to look like a feature more than a bugfix. And while graph feature is definitely great and useful, it seems like it's less used and doesn't produce error now, just works a bit incorrectly.

Assume that we have multiple platform in Dependencies.swift and we're importing carthage dependencies as binaries. Now it will just hide the framework dependency. I will add support for framework dependencies in graph just a bit later in separate PR if you don't mind

[laxmorek]

I left a few minor comments. I think it is fine to push this fix into main and add framework support later.