Adding support for resource folder references #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Resources are now `FileElement`s to support folder references - Resource folder references are added to the project and copied to the final product (bundle resources)
Generated by π« Danger |
Codecov Report
@@ Coverage Diff @@
## master #318 +/- ##
==========================================
+ Coverage 89.48% 89.69% +0.21%
==========================================
Files 280 280
Lines 10707 10793 +86
==========================================
+ Hits 9581 9681 +100
+ Misses 1126 1112 -14
Continue to review full report at Codecov.
|
pepicrft
reviewed
Apr 6, 2019
| @@ -65,3 +65,19 @@ extension FileElement: ExpressibleByStringLiteral { | |||
| self = .glob(pattern: value) | |||
| } | |||
| } | |||
|
|
|||
| extension Array: ExpressibleByUnicodeScalarLiteral where Element == FileElement { | |||
pepicrft
reviewed
Apr 8, 2019
| var fileHandler: MockFileHandler! | ||
| override func setUp() { | ||
| do { | ||
| fileHandler = try MockFileHandler() |
There was a problem hiding this comment.
It should be safe to go with try! MockFileHandler() here but all good π
pepicrft
reviewed
Apr 8, 2019
| @@ -72,6 +72,8 @@ Scenario: The project is an iOS application that has resources (ios_app_with_fra | |||
| Then tuist generates the project | |||
| Then I should be able to build the scheme App | |||
| Then the product 'App.app' with destination 'Debug-iphoneos' contains resource 'tuist.png' | |||
| Then the product 'App.app' with destination 'Debug-iphoneos' contains resource 'Examples/item.json' | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #202
Short description π
Resources to include in an application can be in the form of files as well as folder references.
Solution π¦
Add support for folder references within target resources. For consistency, we can use
FileElementwhich has already been used inProjectandWorkspaceto define additional files.e.g.
Implementation π©βπ»π¨βπ»
Test Plan β
Verify unit tests pass via
swift testVerify acceptance tests pass via
bundle exec rake featuresRun
tuist generatewithinfixtures/ios_app_with_framework_and_resourcesInspect the generated workspace
Verify
MainApphas a folder reference toExampleswhich is also included in the Copy Bundle Resources phase