Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Swift 5 Warnings #325

Merged
merged 2 commits into from Apr 14, 2019
Merged

Conversation

kwridan
Copy link
Collaborator

@kwridan kwridan commented Apr 14, 2019

Part of #316

Short description 📝

A few warnings are displayed when building Tuist with Swift 5. Most of the warnings are generated by the SwiftPM dependency.

e.g.

.build/checkouts/swift-package-manager-7533872658195579349/Sources/Basic/ByteString.swift:95:16: warning: 'Hashable.hashValue' is deprecated as a protocol requirement; conform type 'ByteString' to 'Hashable' by implementing 'hash(into:)' instead
    public var hashValue: Int {

Solution 📦

Update the revision the Swift PM dependency points to one that has been updated for Swift 5.

Implementation 👩‍💻👨‍💻

  • Update asString to pathString
  • Update import Utility to SPMUtility
  • Fix any remaining warnings

Test Plan 🛠

  • Verify unit tests pass swift test
  • Verify acceptance tests pass bundle exec rake features

- `asString` has been renamed to `pathString`
- `Utility` module has been renamed to `SPMUtility`

Test Plan:

- Verify unit tests pass `swift test`
- Verify acceptance tests pass `bundle exec rake features`
@tuistbot
Copy link
Contributor

2 Warnings
⚠️ Please include a CHANGELOG entry.
You can find it at CHANGELOG.md.
⚠️ Have you introduced any user-facing changes? If so, please take some time to update the documentation. Keeping the documentation up to date makes it easier for users to learn how to use Tuist.

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Apr 14, 2019

Codecov Report

Merging #325 into master will decrease coverage by <.01%.
The diff coverage is 93.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
- Coverage   89.32%   89.31%   -0.01%     
==========================================
  Files         277      278       +1     
  Lines       12163    12172       +9     
==========================================
+ Hits        10864    10872       +8     
- Misses       1299     1300       +1
Impacted Files Coverage Δ
...istKitTests/Commands/CreateIssueCommandTests.swift 100% <ø> (ø) ⬆️
...uistEnvKitTests/Commands/InstallCommandTests.swift 100% <ø> (ø) ⬆️
Sources/TuistEnvKit/Commands/InstallCommand.swift 81.48% <ø> (ø) ⬆️
Sources/TuistKit/Commands/DumpCommand.swift 75% <ø> (ø) ⬆️
Sources/TuistKit/Commands/VersionCommand.swift 0% <ø> (ø) ⬆️
...tTests/Versions/Mocks/MockVersionsController.swift 95.45% <ø> (ø) ⬆️
Sources/TuistEnvKit/GitHub/GitHubClient.swift 43.13% <ø> (ø) ⬆️
.../TuistCoreTesting/Commands/MockHiddenCommand.swift 0% <ø> (ø) ⬆️
...sts/TuistKitTests/Commands/FocusCommandTests.swift 100% <ø> (ø) ⬆️
Sources/TuistKit/Commands/UpCommand.swift 75% <ø> (ø) ⬆️
... and 96 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcbbfb1...a4d6905. Read the comment docs.

@kwridan kwridan merged commit 1dd8ace into tuist:master Apr 14, 2019
@kwridan kwridan deleted the feature/swift5-swiftpm branch April 14, 2019 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants