fix handling default spm resources #3295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieleformichelli
requested changes
Aug 13, 2021
Sources/TuistDependencies/SwiftPackageManager/Utils/PackageInfoMapper.swift
Outdated
Show resolved
Hide resolved
Sources/TuistDependencies/SwiftPackageManager/Utils/PackageInfoMapper.swift
Outdated
Show resolved
Hide resolved
Sources/TuistDependencies/SwiftPackageManager/Utils/PackageInfoMapper.swift
Outdated
Show resolved
Hide resolved
|
Converting to draft as it needs work from #3305 before being mergeable |
4 tasks
mstfy
force-pushed
the
dependencies-spm-default-resources-fix
branch
from
ef2b805
to
1e41e68
Compare
Sources/TuistDependencies/SwiftPackageManager/Utils/PackageInfoMapper.swift
Outdated
Show resolved
Hide resolved
Sources/TuistDependencies/SwiftPackageManager/Utils/PackageInfoMapper.swift
Outdated
Show resolved
Hide resolved
Sources/TuistDependenciesTesting/DependenciesGraph/DependenciesGraph+TestData.swift
Outdated
Show resolved
Hide resolved
Tests/TuistDependenciesTests/SwiftPackageManager/Utils/PackageInfoMapperTests.swift
Show resolved
Hide resolved
Tests/TuistDependenciesTests/SwiftPackageManager/Utils/PackageInfoMapperTests.swift
Outdated
Show resolved
Hide resolved
danieleformichelli
approved these changes
Sep 30, 2021
fortmarek
approved these changes
Oct 4, 2021
Sources/TuistDependencies/SwiftPackageManager/Utils/PackageInfoMapper.swift
Show resolved
Hide resolved
luispadron
approved these changes
Oct 4, 2021
danieleformichelli
approved these changes
Oct 5, 2021
mstfy
force-pushed
the
dependencies-spm-default-resources-fix
branch
from
521c5a7
to
28818bb
Compare
mstfy
force-pushed
the
dependencies-spm-default-resources-fix
branch
from
0b7c755
to
c085799
Compare
danieleformichelli
approved these changes
Oct 8, 2021
Sources/TuistDependencies/SwiftPackageManager/Utils/PackageInfoMapper.swift
Outdated
Show resolved
Hide resolved
...uistDependenciesTests/SwiftPackageManager/Utils/SwiftPackageManagerGraphGeneratorTests.swift
Outdated
Show resolved
Hide resolved
danieleformichelli
approved these changes
Oct 8, 2021
This was referenced Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description: Fixes adding default resources to generated project from external spm dependency.
Long Description: When SPM used with xcode some of the resources automatically handled by xcode. There is no need to add them into Package.swift file as resource as long as they are inside the sources folder of the target. These files are interface builder files(xib, storyboard), core data models(xcdatamodeld, xcmappingmodel), asset catalogs (xcassets) and lproj files. In current dependencies implementation of tuist these files are are not getting included in the generated xcode project. This pr addresses this issue.