Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --reinstall-app parameter for test command #3367

Closed
wants to merge 11 commits into from
Closed

Conversation

olejnjak
Copy link
Collaborator

Short description 📝

Sometimes it is useful to make sure that we have clean app target when running app tests (e.g. in case of database migrations).

This PR adds --reinstall-app parameter to test command that uninstalls apps before running tests.

Checklist ✅

  • The code architecture and patterns are consistent with the rest of the codebase.
  • The changes have been tested following the documented guidelines.
  • The CHANGELOG.md has been updated to reflect the changes. In case of a breaking change, it's been flagged as such.
  • In case the PR introduces changes that affect users, the documentation has been updated.

@fortmarek
Copy link
Member

Thanks @olejnjak!

While definitely being useful, I'm not 100 % sure if we want to incorporate this into tuist core. This might be a good candidate for a task plugin, so you could run something along the lines of tuist exec uninstall-app && tuist test. In the future, tuist's tasks should have access to tuist graph to make the implementation seamless. It's my top priority to start working on tuist tasks, so we can more confidently recommend people to start using tasks for more complicated stuff - which, in the end, will help us keeping tuist lean (something we might have struggled with a little bit in the past).

Some additional input from @tuist/core might be useful here.

@luispadron
Copy link
Collaborator

@fortmarek I agree, this seems specific enough for tasks to handle.

@luispadron
Copy link
Collaborator

As we look to #3374 we have made some decisions to strive for a smaller API footprint & the ability to rethink past APIs. As such, we'll be closing this PR and look to provide a similar experience using Tasks.

Appreciate the work done here and if you'd like to contribute to the tasks works please reach out to us on slack / start a discussion!

@luispadron luispadron closed this Aug 31, 2021
@olejnjak olejnjak deleted the test_reinstall_app branch November 16, 2021 12:15
@olejnjak
Copy link
Collaborator Author

Just a simple question for this, let's say I have task, that uninstalls an app from given simulator, is there any way how to determine which simulator will be used by running tuist test? 🤔 I am not quite sure about it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants