Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Scheme shared flag #341

Merged
merged 4 commits into from May 16, 2019
Merged

Conversation

dangthaison91
Copy link
Contributor

Continue from PR #336

Short description πŸ“

Previously, Scheme will always generated as Shared Scheme despite of shared is set to false.

Solution πŸ“¦

If Scheme is shared, Xcode will generate xcscheme file in folder xcshareddata/xcschemes while scheme is not shared, it will be put in `xcuserdata/user_name.xcuserdatad/xcschemes

As @kwridan share about NSUsername(), we can use this function for appending write path for local scheme.

Implementation πŸ‘©β€πŸ’»πŸ‘¨β€πŸ’»

  • Update function create scheme directory
  • Update tests and fixture

@tuistbot
Copy link
Contributor

tuistbot commented May 7, 2019

1 Warning
⚠️ Have you introduced any user-facing changes? If so, please take some time to update the documentation. Keeping the documentation up to date makes it easier for users to learn how to use Tuist.

Generated by 🚫 Danger

Copy link
Collaborator

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

Copy link
Contributor

@pepicrft pepicrft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely handled @dangthaison91

@dangthaison91
Copy link
Contributor Author

Should we Squash and Merge @pepibumur

@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #341 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
- Coverage   90.81%   90.79%   -0.03%     
==========================================
  Files         281      281              
  Lines       13224    13150      -74     
==========================================
- Hits        12009    11939      -70     
+ Misses       1215     1211       -4
Impacted Files Coverage Ξ”
...neratorTests/Generator/ProjectGeneratorTests.swift 99.18% <100%> (+0.22%) ⬆️
...es/TuistGenerator/Generator/SchemesGenerator.swift 99.61% <100%> (ΓΈ) ⬆️
Sources/TuistGenerator/Graph/Graph.swift 91.22% <0%> (-0.44%) ⬇️
...tKitTests/Generator/GeneratorModelLoaderTest.swift 98.4% <0%> (-0.02%) ⬇️
...rces/TuistKit/Generator/GeneratorModelLoader.swift 91.63% <0%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update a236717...495d9d8. Read the comment docs.

@pepicrft
Copy link
Contributor

Yes @dangthaison91. I was going to do it but it's your honour πŸ˜›

@dangthaison91 dangthaison91 merged commit a8eb839 into tuist:master May 16, 2019
@dangthaison91 dangthaison91 deleted the shared-scheme branch May 17, 2019 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants