New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Scheme shared
flag
#341
Conversation
Generated by π« Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely handled @dangthaison91
Should we |
c55d7c4
to
495d9d8
Compare
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
==========================================
- Coverage 90.81% 90.79% -0.03%
==========================================
Files 281 281
Lines 13224 13150 -74
==========================================
- Hits 12009 11939 -70
+ Misses 1215 1211 -4
Continue to review full report at Codecov.
|
Yes @dangthaison91. I was going to do it but it's your honour π |
Continue from PR #336
Short description π
Previously, Scheme will always generated as Shared Scheme despite of shared is set to false.
Solution π¦
If Scheme is shared, Xcode will generate xcscheme file in folder
xcshareddata/xcschemes
while scheme is not shared, it will be put in `xcuserdata/user_name.xcuserdatad/xcschemesAs @kwridan share about
NSUsername()
, we can use this function for appending write path for local scheme.Implementation π©βπ»π¨βπ»