Fixing generation failures due to asset catalog & **/*.png glob patterns handling
#346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rns handling Resolves tuist#345 - Using the `**/*` style patterns are "eager" they will list out files recursively including ones within `.xcassets` - The order in which the `ProjectFileElements` elements are processes isn't guaranteed - If a file within the `.xcassets` is encountered first, e.g. `App/Resources/Assets.xcassets/assetCatalogLogo.imageset/tuist.png` before `App/Resources/Assets.xcassets`, `App/Resources/Assets.xcassets` is mistaken for a group and isn't added as a file element - To mitigate this, the logic that determines if a group or file is added checks for `.xcassets` files Test Plan: - Verify unit tests pass - Verify acceptance tests pass - Run `tuist generate` within `fixtures/ios_app_with_framework_and_resources` - Verify the generation passes - Verify the asset catalog is included in the generated `MainApp` within the workspace
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
=========================================
+ Coverage 90.66% 90.7% +0.03%
=========================================
Files 281 281
Lines 12982 13026 +44
=========================================
+ Hits 11770 11815 +45
+ Misses 1212 1211 -1
Continue to review full report at Codecov.
|
pepicrft
approved these changes
May 10, 2019
|
Ignore the CI checks from Netlify that are failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #345
Short description 📝
**/*style patterns are "eager" they will list out files recursively including ones within.xcassetsProjectFileElementselements are processes isn't guaranteed.xcassetsis encountered first, e.g.App/Resources/Assets.xcassets/assetCatalogLogo.imageset/tuist.pngbeforeApp/Resources/Assets.xcassets,App/Resources/Assets.xcassetsis mistaken for a group and isn't added as a file elementSolution 📦
.xcassetsfilesImplementation 👩💻👨💻
.xcassetsTest Plan 🛠
tuist generatewithinfixtures/ios_app_with_framework_and_resourcesMainAppwithin the workspace