New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add input & output paths for target action #353
Add input & output paths for target action #353
Conversation
Generated by 🚫 Danger |
Not necessary. Once you add the logic to set the values to the build phase I'd write a test that verifies that the build phase is created with the right attributes. Don't forget to update the CHANGELOG.md and the documentation because this is a user-facing feature. |
Sorry for slow response, today I'll update PR. |
No rush @Rag0n 😛 |
46c168b
to
269c3d5
Compare
269c3d5
to
957a05b
Compare
Rebased branch and updated with master |
I've made the changes necessary to get this pull request merged, feel free to review it @Rag0n @pepibumur |
Codecov Report
@@ Coverage Diff @@
## master #353 +/- ##
=========================================
Coverage ? 91.95%
=========================================
Files ? 292
Lines ? 14838
Branches ? 0
=========================================
Hits ? 13645
Misses ? 1193
Partials ? 0
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good @ollieatkinson 👍
Resolves #342
Short description 📝
Add ability to specify input/output files or file lists.
Solution 📦
Add inputPaths, inputFileListPaths, outputPaths, outputFileListPaths parameters to
TargetAction
.Implementation 👩💻👨💻
TargetAction
ProjectDescription.TargetAction
toTuistGenerator.TargetAction
BuildPhaseGenerator
Let me know if I need to write tests. I saw
TargetActionTests
, but it seems like you doesn't cover encoding/decoding by unit tests. Should I write integration tests?