Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input & output paths for target action #353

Merged
merged 6 commits into from Jun 10, 2019

Conversation

Rag0n
Copy link
Contributor

@Rag0n Rag0n commented May 14, 2019

Resolves #342

Short description 📝

Add ability to specify input/output files or file lists.

Solution 📦

Add inputPaths, inputFileListPaths, outputPaths, outputFileListPaths parameters to TargetAction.

Implementation 👩‍💻👨‍💻

Detail in a checklist the steps that you took to implement the PR.

  • Add parameters to TargetAction
  • Update conversion from ProjectDescription.TargetAction to TuistGenerator.TargetAction
  • Pass parameters to BuildPhaseGenerator

Let me know if I need to write tests. I saw TargetActionTests, but it seems like you doesn't cover encoding/decoding by unit tests. Should I write integration tests?

@tuistbot
Copy link
Contributor

tuistbot commented May 14, 2019

1 Warning
⚠️ Have you introduced any user-facing changes? If so, please take some time to update the documentation. Keeping the documentation up to date makes it easier for users to learn how to use Tuist.

Generated by 🚫 Danger

@pepicrft
Copy link
Contributor

Let me know if I need to write tests. I saw TargetActionTests, but it seems like you doesn't cover encoding/decoding by unit tests. Should I write integration tests?

Not necessary. Once you add the logic to set the values to the build phase I'd write a test that verifies that the build phase is created with the right attributes.

Don't forget to update the CHANGELOG.md and the documentation because this is a user-facing feature.

@kwridan kwridan mentioned this pull request May 15, 2019
@Rag0n
Copy link
Contributor Author

Rag0n commented May 22, 2019

Sorry for slow response, today I'll update PR.

@pepicrft
Copy link
Contributor

No rush @Rag0n 😛

@ollieatkinson
Copy link
Collaborator

Rebased branch and updated with master

@ollieatkinson ollieatkinson requested a review from a team June 9, 2019 20:27
@ollieatkinson
Copy link
Collaborator

I've made the changes necessary to get this pull request merged, feel free to review it @Rag0n @pepibumur

@codecov
Copy link

codecov bot commented Jun 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@fdbb740). Click here to learn what that means.
The diff coverage is 56.64%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #353   +/-   ##
=========================================
  Coverage          ?   91.95%           
=========================================
  Files             ?      292           
  Lines             ?    14838           
  Branches          ?        0           
=========================================
  Hits              ?    13645           
  Misses            ?     1193           
  Partials          ?        0
Impacted Files Coverage Δ
...rces/TuistKit/Generator/GeneratorModelLoader.swift 92.21% <100%> (ø)
Sources/TuistGenerator/Models/TargetAction.swift 100% <100%> (ø)
...TuistGenerator/Generator/BuildPhaseGenerator.swift 97.43% <100%> (ø)
Sources/ProjectDescription/TargetAction.swift 50% <35.48%> (ø)
...eneratorTests/Generator/TargetGeneratorTests.swift 98.44% <92.85%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdbb740...cb9de93. Read the comment docs.

@ollieatkinson ollieatkinson added this to the 0.16.0 milestone Jun 9, 2019
Copy link
Contributor

@pepicrft pepicrft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good @ollieatkinson 👍

@ollieatkinson ollieatkinson merged commit 034c84d into tuist:master Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TargetAction doesn't allow to specify input/output files or file lists
4 participants