Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tuist generate performance regression of ModuleMapMapper #3562

Merged
merged 5 commits into from
Oct 15, 2021

Conversation

adellibovi
Copy link
Collaborator

@adellibovi adellibovi commented Oct 14, 2021

Short description 📝

There was a regression of performance introduced with the new ModuleMapMapper. This PR tries to fix it.
Pre ModuleMapMapper I had a dirty tuist generate of <5s, with it I could reach ~18s. This change brings it back to ~5s.
There are two commits:

  • one that introduces the use of dictionary instead of first
  • another one caches any processed target, before we were excluding the ones that did not produce any dependenciesModuleMaps

Checklist ✅

  • The code architecture and patterns are consistent with the rest of the codebase.
  • The changes have been tested following the documented guidelines.
  • The CHANGELOG.md has been updated to reflect the changes. In case of a breaking change, it's been flagged as such.
  • In case the PR introduces changes that affect users, the documentation has been updated.

@pepicrft pepicrft merged commit aa7165b into main Oct 15, 2021
@pepicrft pepicrft deleted the fix-performance-modulemapmapper branch October 15, 2021 16:15
ezraberch added a commit to ezraberch/tuist that referenced this pull request Oct 20, 2021
danieleformichelli pushed a commit that referenced this pull request Oct 21, 2021
…il (#3581)

* Fix regression in #3562 causing custom configuration build test to fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants