Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Better define how a target supports resources #3572

Merged
merged 3 commits into from
Oct 19, 2021

Conversation

fila95
Copy link
Contributor

@fila95 fila95 commented Oct 19, 2021

Short description πŸ“

As per title this PR fixes the implementation of supportsResources excluding commandLineTools and using compiler safety.

Checklist βœ…

  • The code architecture and patterns are consistent with the rest of the codebase.
  • The changes have been tested following the documented guidelines.
  • The CHANGELOG.md has been updated to reflect the changes. In case of a breaking change, it's been flagged as such.
  • In case the PR introduces changes that affect users, the documentation has been updated.

Copy link
Collaborator

@danieleformichelli danieleformichelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much more clear (I was always understanding it reverted before), and future proof (as adding new case will force us to add them here)

Sources/TuistGraph/Models/Target.swift Outdated Show resolved Hide resolved
Co-authored-by: Daniele Formichelli <df@bendingspoons.com>
@pepicrft pepicrft merged commit c9854b7 into main Oct 19, 2021
@pepicrft pepicrft deleted the fix/supports-resources branch October 19, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants