Add preActions and postActions to RunAction and ProfileAction
#3787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hisaac
requested review from
RomainBoulay and
natanrolnik
and removed request for
a team
kwridan
reviewed
Dec 5, 2021
There was a problem hiding this comment.
Thanks for submitting this @hisaac
I believe the missing connection is updating the SchemeDescriptorGenerator which is responsible for generating the Xcode schemes (descriptors).
|
Thank you @kwridan! I'll take a look there and see if I can sort it out. |
Fix tests Undo some unnecessary refactoring Revert changes to AnalyzeAction Refactor for code style
hisaac
force-pushed
the
add-pre-and-post-scheme-actions
branch
from
0aceac4
to
a050f51
Compare
|
This should be ready for final review now. I've tested the changes on one of my projects, and have confirmed that it's working. |
hisaac
changed the title
preActions and postActions to RunAction and ProfileActionpreActions and postActions to RunAction and ProfileAction
kwridan
approved these changes
Dec 9, 2021
There was a problem hiding this comment.
Thanks for contributing this and bringing consistency to the schemes APIs @hisaac 🎉
I've also tested locally with the ios_app_with_custom_scheme fixture
fortmarek
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was generated from a question in the Tuist Slack here: https://tuistapp.slack.com/archives/CTB0DBVD2/p1638098676119800
Short description 📝
In one of my projects, I use a custom pre-action on one of my scheme's Run action. When attempting to migrate said project to Tuist, I noticed that Tuist does not support adding pre-actions or post-actions to
RunAction, as well asProfileActionandAnalyzeAction.This PR is to add pre-actions and post-actions to
RunActionandProfileAction. (I learned while working on this that Xcode does not support pre-actions and post-actions on Analyze actions, so I'm leaving that one as-is.)Checklist ✅
CHANGELOG.mdhas been updated to reflect the changes. In case of a breaking change, it's been flagged as such.TuistGraph.Target, theConstants.cacheVersionhas been updated.