Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swiftui template #3840

Merged
merged 5 commits into from Dec 26, 2021
Merged

Update swiftui template #3840

merged 5 commits into from Dec 26, 2021

Conversation

ezraberch
Copy link
Contributor

@ezraberch ezraberch commented Dec 15, 2021

Short description πŸ“

The current swiftui template isn't functional out-of-the-box; while it will build and run, running the generated project will not display the "Hello, World!" from the SwiftUI view. It is also not fully SwiftUI.

This PR revamps the template, using the default Xcode template as a base. Additionally, in doing so I discovered that using .directory() in a template does not work under certain conditions, so this has been fixed. Like the existing template, the new template supports macOS, iOS, and tvOS.

Checklist βœ…

  • The code architecture and patterns are consistent with the rest of the codebase.
  • The changes have been tested following the documented guidelines.
  • The CHANGELOG.md has been updated to reflect the changes. In case of a breaking change, it's been flagged as such.
  • In case the PR introduces changes that affect users, the documentation has been updated.
  • In case the PR introduces changes that affect how the cache artifact is generated starting from the TuistGraph.Target, the Constants.cacheVersion has been updated.

* Fix handling of Template.Item.Directory
Copy link
Member

@fortmarek fortmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works great, thanks @ezraberch πŸ‘

@pepicrft pepicrft merged commit 63526a7 into main Dec 26, 2021
@pepicrft pepicrft deleted the update-swiftui-template branch December 26, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants