Build settings have the same values repeated multiple times #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## master #391 +/- ##
==========================================
+ Coverage 92.16% 92.16% +<.01%
==========================================
Files 291 291
Lines 14585 14605 +20
==========================================
+ Hits 13442 13461 +19
- Misses 1143 1144 +1
Continue to review full report at Codecov.
|
kwridan
approved these changes
Jun 5, 2019
CHANGELOG.md
Outdated
| @@ -19,6 +19,7 @@ Please, check out guidelines: https://keepachangelog.com/en/1.0.0/ | |||
|
|
|||
| ### Fixed | |||
|
|
|||
| - Fixing build settings repeated same value https://github.com/tuist/tuist/pull/391 @platonsi | |||
There was a problem hiding this comment.
oops, looks like the entry was added under the previous version, this can go to the Next Version section. Pulling in the latest master should include Fixed section from yesterday
platonsi
force-pushed
the
bugs/buildSettings
branch
from
ad6a469
to
e7eb36f
Compare
|
Thanks for fixing this @platonsi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #390
Short description 📝
The
DefaultSettingsProvidertargetSettingscombines the build settings for the specified build variant with the build settings for variants. If there is a common build setting with$(inherited)in its value, the value is appended twice.Solution 📦
In the
SettingsHelperbefore combining build settings by appending the new value to the existing one check if the value are equalImplementation 👩💻👨💻
SettingsHelperto check if setting values are equal before appendingTest Plan 🛠