Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .d as a valid source extension #396

Merged
merged 2 commits into from Jun 7, 2019
Merged

Add .d as a valid source extension #396

merged 2 commits into from Jun 7, 2019

Conversation

pepicrft
Copy link
Contributor

@pepicrft pepicrft commented Jun 7, 2019

Short description πŸ“

We were filtering out .d files from the list of sources.

Solution πŸ“¦

Change the validSourceExtensions value to include files with the .d extension.

Implementation πŸ‘©β€πŸ’»πŸ‘¨β€πŸ’»

  • Update the value.
  • Fix the tests.
  • Update CHANGELOG.

cc @RomainBoulay

@pepicrft pepicrft self-assigned this Jun 7, 2019
@pepicrft pepicrft requested a review from a team June 7, 2019 02:01
@tuistbot
Copy link
Contributor

tuistbot commented Jun 7, 2019

1 Warning
⚠️ Have you introduced any user-facing changes? If so, please take some time to update the documentation. Keeping the documentation up to date makes it easier for users to learn how to use Tuist.

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #396 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #396   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files         291      291           
  Lines       14615    14615           
=======================================
  Hits        13473    13473           
  Misses       1142     1142
Impacted Files Coverage Ξ”
Sources/TuistGenerator/Models/Target.swift 95.52% <ΓΈ> (ΓΈ) ⬆️
Tests/TuistGeneratorTests/Models/TargetTests.swift 98.88% <100%> (ΓΈ) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 1f47fc0...8115275. Read the comment docs.

Copy link
Contributor

@RomainBoulay RomainBoulay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shipit

@pepicrft pepicrft merged commit 41c36d5 into master Jun 7, 2019
@pepicrft pepicrft deleted the d-source branch June 7, 2019 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants