Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for frameworks as dependency of tvOS frameworks #4184

Merged
merged 1 commit into from Apr 12, 2022

Conversation

zdnk
Copy link
Contributor

@zdnk zdnk commented Feb 22, 2022

Resolves #4154

Short description πŸ“

add framework as valid linkable product to tvOS products

How to test the changes locally 🧐

  1. create Dependencies.swift from SPM with nested SPM dependencies that build as framework
  2. add them to target
  3. generate project

Checklist βœ…

  • The code architecture and patterns are consistent with the rest of the codebase.
  • The changes have been tested following the documented guidelines.
  • The CHANGELOG.md has been updated to reflect the changes. In case of a breaking change, it's been flagged as such.
  • In case the PR introduces changes that affect users, the documentation has been updated.
  • In case the PR introduces changes that affect how the cache artifact is generated starting from the TuistGraph.Target, the Constants.cacheVersion has been updated.

Copy link
Collaborator

@danieleformichelli danieleformichelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any tvOS fixture in project/tuist/fixtures?
If not, it could be worth to add one.
If yes, it could be worth to extend it to include this scenario.

πŸš€

Copy link
Collaborator

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zdnk

@zdnk
Copy link
Contributor Author

zdnk commented Feb 22, 2022

need to fix the tests somehow, but dont know what the issue

@zdnk
Copy link
Contributor Author

zdnk commented Mar 10, 2022

well? :)

@danieleformichelli
Copy link
Collaborator

well? :)

Hey @zdnk , could you add the scenario to a fixture, as asked here?

@github-actions
Copy link
Contributor

This PR has been marked as stale because it's been opened for more than 30 days. If no action is taken, it'll be closed in 5 days.

@danieleformichelli danieleformichelli added the changelog:fixed PR will be listed in the Fixed section of CHANGELOG label Apr 12, 2022
@danieleformichelli danieleformichelli changed the title fix: add missing linkable framework Fix support for frameworks as dependency of tvOS frameworks Apr 12, 2022
@danieleformichelli danieleformichelli merged commit c2f57bd into main Apr 12, 2022
@danieleformichelli danieleformichelli deleted the bugfix/add-linkable-framework-tvos branch April 12, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:fixed PR will be listed in the Fixed section of CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dependencies.swift][SPM] Nested dependencies cannot link correctly
3 participants