Add new InfoPlist.extendingDefault case #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepicrft
changed the title
pepicrft
changed the title
Codecov Report
@@ Coverage Diff @@
## master #448 +/- ##
==========================================
+ Coverage 92.6% 92.69% +0.09%
==========================================
Files 347 350 +3
Lines 17815 18077 +262
==========================================
+ Hits 16497 16756 +259
- Misses 1318 1321 +3
Continue to review full report at Codecov.
|
pepicrft
force-pushed
the
infoplist-default-extended
branch
from
868910e
to
3601cbf
Compare
Generated by 🚫 Danger |
|
This PR is ready for review @tuist/core |
pepicrft
changed the title
pepicrft
commented
Aug 3, 2019
kwridan
reviewed
Aug 7, 2019
Tests/TuistGeneratorTests/Generator/InfoPlistContentProviderTests.swift
Outdated
Show resolved
Hide resolved
pepicrft
force-pushed
the
infoplist-default-extended
branch
from
53dbe89
to
38bb503
Compare
added 8 commits
September 2, 2019 18:58
…hen it's a .extendingDefault Info.plist.
pepicrft
force-pushed
the
infoplist-default-extended
branch
from
38bb503
to
6a85b39
Compare
|
@ollieatkinson / @kwridan this is ready for another look. |
ollieatkinson
approved these changes
Sep 3, 2019
| @@ -0,0 +1 @@ | |||
| Derived/ | |||
There was a problem hiding this comment.
Do we want .gitignore at this level?
There was a problem hiding this comment.
I'd say so. That way we can run the test assuming there are no files in that directory.
| let project = Project(name: "MainApp", | ||
| settings: settings, | ||
| targets: [ | ||
| Target(name: "App", | ||
| platform: .iOS, | ||
| product: .app, | ||
| bundleId: "io.tuist.App", | ||
| infoPlist: "Config/App-Info.plist", | ||
| infoPlist: .extendingDefault(with: [:]), |
There was a problem hiding this comment.
is it worth adding a custom value?
There was a problem hiding this comment.
That's already being tested with unit tests, so I don't think it adds much value.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Tuist seeks to remove duplications and hide intricacies from developers' projects and workflows, the content of the
Info.plistis a good candidate to be managed by Tuist.Solution 📦
Tuist already supports passing the content of the target's Info.plist to the manifest. However, the whole content needs to be included in the dictionary, providing no benefit to the user compared to having the content in an
Info.plistfile.This PR extends the
InfoPlistmodel to add a new case,InfoPlist.extendingDefault(with: ["CFBundleShortVersionString": "3.2.1"]). Tuist provides the base values based on the product type and the platform and extends them using the values provided by the user.Implementation 👩💻👨💻
InfoPlistContentProviderDerivedFileGeneratorgeneration logic to get the content using theInfoPlistContentProvider.