Fix: lproj directories not being detected as resources

[ffittschen]

Resolves #4505
Request for comments document (if applies): -

Short description 📝

Adds the lproj extension to the validFolderExtensions so that the isResource(path:) will return true instead of false when it's input is a lproj directory.

Question for the maintainers: Is the addition in the tests enough, or should I also add some lproj to any fixtures to assert that a ...Resources target is being generated?

How to test the changes locally 🧐

1. Use the sample project attached to Resources bundle not generated for SPM dependency #4505
2. Run tuist fetch && tuist generate
3. Open the AppCenter project in Tuist > Dependencies > SwiftPackageManager > .build > checkouts
4. See that Tuist generated the AppCenterDistributeResources target

Checklist ✅

• The code architecture and patterns are consistent with the rest of the codebase.
• The changes have been tested following the documented guidelines.
• The PR includes the label changelog:added, changelog:fixed, or changelog:changed, whenever it should be included in the “Added”, “Fixed” or “Changed” section of the CHANGELOG. Note: when included in the CHANGELOG, the title of the PR will be used as entry, please make sure it is clear and suitable.
• In case the PR introduces changes that affect users, the documentation has been updated.
• In case the PR introduces changes that affect how the cache artifact is generated starting from the TuistGraph.Target, the Constants.cacheVersion has been updated.

[danieleformichelli]

I'm not sure it's the right fix, because AFAIK adding lproj folder as resources works fine in general, and the issue is only when they are added as automatic resources from SPM, so there might be something different in that path to be investigated

[ffittschen]

Fair enough. I'll try to find out if we could mimic the workaround explained in #4435 (comment), i.e. assuming the Package.swift file has resources: [.process("Resources"] if it in fact does not, but a Resources directory exists.

[danieleformichelli]

Fair enough. I'll try to find out if we could mimic the workaround explained in #4435 (comment), i.e. assuming the Package.swift file has resources: [.process("Resources"] if it in fact does not, but a Resources directory exists.

the logic is already there, but it looks like the lproj are handled by a different logic WRT other resources, and that logic is missing somehow for targets coming from Dependencies.swift

[danieleformichelli]

This should be the required fix: #4532