Do Not Create Derived/InfoPlists
Folder When No InfoPlist Dictionary Specified
#456
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #449
Short description 📝
This pull request should fix creating the
Derived/InfoPlists
unnecessarily when an InfoPlist dictionary is not specified.Solution 📦
Check
targetsWithGeneratableInfoPlists
is not empty before creating theDerived/InfoPlists
folder otherwise do not create the folder.Implementation 👩💻👨💻
targetsWithGeneratableInfoPlists
not being empty before creatingDerived/InfoPlists
folderDerivedFileGeneratorTests
that checks that when an InfoPlist file is specified no folder is created on diskTest Plan
tuist generate
withinfixtures/ios_app_with_frameworks
App
has noDerived/InfoPlists
folderFramework1
hasDerived/InfoPlists
folderFramework2
has noDerived/InfoPlists
folder