Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Custom File Name for
.xcodeproj
at Model Level #462Use Custom File Name for
.xcodeproj
at Model Level #462Changes from 15 commits
051ee9a
f92e139
6e5e0e1
4d32b07
97ba5c2
21a78b2
3fc7f8f
a12b226
366dd0b
6500e5e
8b9ba90
0087ac4
84adc50
434ce16
4f7d0d3
2baba03
284e710
365569c
2f8282d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notice that the model being passed is a reference, so creating another internal variable does not make any copy. I'd just remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do the following operations in the same method:
The idea was to be consistent and continue returning a new model every time a
Project
property is changed.Project
's properties are immutable.The alternative would be to change the
let
s insideProject
tovar
s.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep it like that for now. If we see maintaining those methods that create copies of the instances become cumbersome, we can reconsider the approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that
TuistGenerator.Project
is a class, we don't need to be creating copies of the objects. Whereveradding
andreplacing
is used, I'd just set the attribute to the object and not create new instances of it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is related to my previous comment about
Project
's properties being immutable.