Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linting for mismatching build configurations in a workspace #474

Merged
merged 5 commits into from Aug 4, 2019
Merged

Add linting for mismatching build configurations in a workspace #474

merged 5 commits into from Aug 4, 2019

Commits on Aug 3, 2019

  1. Add linting for mismatching build configurations in a workspace 

    Resolves tuist#467

- All projects' build configurations are now validated against the top level projects
- In the event any are missing or are mismatching (e.g. have a mismatching variant) the linter will now flag them

Examples:

```
$ tuist generate
The following issues have been found:
  - The project 'Framework2' has missing or mismatching configurations. It has [Debug (debug), Release (release)], other projects have  [Beta (release), Debug (debug), Release (release)].
```

Test Plan:

- Run `tuist generate` within `fixtures/ios_app_with_multi_configs`
- Comment out any of the build configurations defined in `App`, `Framework1` or `Framework2`
- Re-run `tuist generate`
- Verify a lint warning is displayed
    @kwridan
    kwridan committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    e455131 View commit details
    Browse the repository at this point in the history

  2. Update changelog

    @kwridan
    kwridan committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    d51bee9 View commit details
    Browse the repository at this point in the history

  3. undo comment formating

    @kwridan
    kwridan committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    27df26a View commit details
    Browse the repository at this point in the history

  4. swift format

    @kwridan
    kwridan committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    6919483 View commit details
    Browse the repository at this point in the history

  5. correcting typo

    @kwridan
    kwridan committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    739ca47 View commit details
    Browse the repository at this point in the history