Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix signing when certificate name contains quotes #4890

Merged
merged 5 commits into from Nov 30, 2022
Merged

Fix signing when certificate name contains quotes #4890

merged 5 commits into from Nov 30, 2022

Conversation

david-all-win-software
Copy link
Contributor

@david-all-win-software david-all-win-software commented Nov 21, 2022 •
edited

Resolves #4889

Short description 📝

Add support for certificates that include quotes in the common name

How to test the changes locally 🧐

  • Added unit tests
  • Use a mock or certificate with a CN with quotes something like: subject=UID = VD55TKL3V6, CN = "Apple Development: Name (54GSF6G47V)", OU = QH95ER52SG, O = "Name", C = US
  • Configure tuist signing with that cert
  • The CODE_SIGN_IDENTITY should be generated without the starting quote

Checklist ✅

  • The code architecture and patterns are consistent with the rest of the codebase
  • The title of the PR will be used as changelog entry, please make sure it is clear and suitable
  • In case the PR introduces changes that affect users, the documentation has been updated
  • Contributors have checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed

@danieleformichelli danieleformichelli changed the title Add quote support in certificate name Fix signing when certificate name contains quotes Nov 29, 2022
@danieleformichelli danieleformichelli added the changelog:fixed PR will be listed in the Fixed section of CHANGELOG label Nov 29, 2022
@david-all-win-software
Copy link
Contributor Author

Hi @danyf90 thanks for approved this PR, I just updated the branch, let me know if I need to do anything else to get it to merge

@danieleformichelli danieleformichelli merged commit 824fdc9 into tuist:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieleformichelli danieleformichelli danieleformichelli approved these changes

@jesus-mg-ios jesus-mg-ios jesus-mg-ios approved these changes

Assignees
No one assigned
Labels
changelog:fixed PR will be listed in the Fixed section of CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tuist Signing: extra character on name of certificate
3 participants
@david-all-win-software @danieleformichelli @jesus-mg-ios