Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent embedding static frameworks #490

Merged

Commits on Aug 29, 2019

  1. No longer embed static frameworks

    Resolves tuist#454
    
    - All `FrameworkNodes` (i.e. prebuilt frameworks) were being embedded regardless of their linkage
    - This check was redundant as there was a more general check for `PrecompiledNode` which happens to be the super class of `FrameworkNode` which took into account the framework linkage
    - To resolve this issue it was suffice to remove the redundant check
    
    Test Plan:
    
    - Generate `fixtures/ios_app_with_static_frameworks` via running `tuist generate`
    - Verify the generated project doesn't embed `PrebuiltStaticFramework`
    - Verify the generated project builds successfully
    kwridan committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    d668967 View commit details
    Browse the repository at this point in the history
  2. Update changelog

    kwridan committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    2bebabc View commit details
    Browse the repository at this point in the history
  3. swiftformat

    kwridan committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    a45c0e8 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2019

  1. Configuration menu
    Copy the full SHA
    d24c2ef View commit details
    Browse the repository at this point in the history