Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print the codesign output #492

Merged
merged 2 commits into from Sep 10, 2019
Merged

Print the codesign output #492

merged 2 commits into from Sep 10, 2019

Conversation

pepicrft
Copy link
Contributor

@pepicrft pepicrft commented Sep 7, 2019

Short description 📝

Yesterday, while debugging an issue with @asalom that caused the copy frameworks phase to fail, we found that we are not printing the output of the codesign. Due to that, when the command fails for whatever reason, it's really hard to debug.

Solution 📦

Use runAndPrint instead of just run, which will show the output of the codesign command.

@pepicrft pepicrft requested a review from a team September 7, 2019 08:30
@pepicrft pepicrft self-assigned this Sep 7, 2019
@codecov
Copy link

codecov bot commented Sep 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@083defa). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #492   +/-   ##
=========================================
  Coverage          ?   92.69%           
=========================================
  Files             ?      350           
  Lines             ?    18077           
  Branches          ?        0           
=========================================
  Hits              ?    16756           
  Misses            ?     1321           
  Partials          ?        0
Impacted Files Coverage Δ
Sources/TuistKit/Embed/FrameworkEmbedder.swift 81.81% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 083defa...91c04d8. Read the comment docs.

@tuistbot
Copy link
Contributor

tuistbot commented Sep 7, 2019

1 Warning
⚠️ Have you introduced any user-facing changes? If so, please take some time to update the documentation. Keeping the documentation up to date makes it easier for users to learn how to use Tuist.

SwiftLint found issues

Warnings

File Line Reason
FrameworkEmbedder.swift 62 Line should be 150 characters or less: currently 163 characters (line_length)
FrameworkEmbedder.swift 83 Line should be 150 characters or less: currently 151 characters (line_length)

Generated by 🚫 Danger

@pepicrft pepicrft merged commit e9dfae1 into master Sep 10, 2019
@pepicrft pepicrft deleted the print-codesign-ouptut branch September 10, 2019 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants