Fix build phases not being generated in the right positions #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepicrft
commented
Sep 19, 2019
| And I have a working directory | ||
| Then I copy the fixture ios_app_with_actions into the working directory | ||
| Then tuist generates the project | ||
| Then the target App should have the build phase Tuist in the first position |
There was a problem hiding this comment.
@parse am I right defining in this test what you expect in the generated project?
There was a problem hiding this comment.
Awesome! With this test in place we'll make sure we don't introduce regressions in the future.
SwiftLint found issuesWarnings
Generated by π« Danger |
pepicrft
force-pushed
the
post-action-last
branch
from
51c9330
to
928eac6
Compare
Codecov Report
@@ Coverage Diff @@
## master #506 +/- ##
==========================================
+ Coverage 92.17% 92.18% +0.01%
==========================================
Files 352 352
Lines 18450 18461 +11
==========================================
+ Hits 17006 17018 +12
+ Misses 1444 1443 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #505
Short description π
As @parse reported, the target actions were not generated in the right position. That happens because after calling the build phases generator, we call the link phases generator which might insert phases after the post actions.
Solution π¦
Move the calls to generate the target actions to the
TargetGenerator.Implementation π©βπ»π¨βπ»