Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Info.plist default for iOS for Xcode 14.2 #5067

Merged
merged 8 commits into from Feb 28, 2023

Conversation

ronanociosoig-200
Copy link
Contributor

@ronanociosoig-200 ronanociosoig-200 commented Feb 26, 2023

Short description πŸ“

Prevents the console reporting this issue for Xcode 14.2 when running an iOS project:
[SceneConfiguration] Info.plist contained no UIScene configuration dictionary

How to test the changes locally 🧐

Requires Xcode 14.2
Create a new project with init.
Generate the project
Run the opened project.

Without the change the console outputs the following message twice:

[SceneConfiguration] Info.plist contained no UIScene configuration dictionary

Contributor checklist βœ…

  • [βœ…] The code has been linted using run ./fourier lint tuist --fix
  • [βœ…] The change is tested via unit testing or acceptance testing, or both
  • [βœ…] The title of the PR is formulated in a way that is usable as a changelog entry
  • [βœ…] In case the PR introduces changes that affect users, the documentation has been updated

Reviewer checklist βœ…

  • The code architecture and patterns are consistent with the rest of the codebase
  • Contributors have checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed, and the title is usable as a changelog entry

…t a warning in the console about missing UIScene configuration dictionary
Copy link
Collaborator

@danieleformichelli danieleformichelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failing tests πŸ™

@danieleformichelli danieleformichelli merged commit dbd6a88 into main Feb 28, 2023
@danieleformichelli danieleformichelli deleted the update/ExtendDefaultPlist branch February 28, 2023 19:43
@danieleformichelli danieleformichelli added the changelog:fixed PR will be listed in the Fixed section of CHANGELOG label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:fixed PR will be listed in the Fixed section of CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants