-
-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with MacCatalyst archiving not being included in build cache when caching XCFramework
#5108
Fix issue with MacCatalyst archiving not being included in build cache when caching XCFramework
#5108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great PR 👏 It would be great if you could write an acceptance test here to test on the CI the maccatalyst project builds, so we don't have any further regressions here. You can read more about our acceptance tests in our docs.
I haven't tried Acceptance Tests before, but I'll give it a shot based on the documentation and previous work. |
0ff2df5
to
cd79640
Compare
…ework-with-catalyst
Thanks a lot again @devyhan for the contribution 👏 |
@fortmarek @danyf90 , I learned a lot thanks to both of you. Thank you. 😁 |
Resolves #4900
Short description 📝
Update
CacheXCFrameworkBuilder
to generate MacCatalyst archives forXCFramework
based on their support status when creating a cache.How to test the changes locally 🧐
Download the sample project through this link and enter the following commands according to the CLI. Afterward, MacCatalyst should be added to the BuildCache as shown in the image below, and the cached sample project should build the MacCatalyst target.
Check the path
~/.tuist/Cache/BuildCache/
Contributor checklist ✅
./fourier lint tuist --fix
Reviewer checklist ✅
changelog:added
,changelog:fixed
, orchangelog:changed
, and the title is usable as a changelog entry