Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with MacCatalyst archiving not being included in build cache when caching XCFramework #5108

Conversation

devyhan
Copy link
Contributor

@devyhan devyhan commented Mar 16, 2023

Resolves #4900

Short description 📝

Update CacheXCFrameworkBuilder to generate MacCatalyst archives for XCFramework based on their support status when creating a cache.

How to test the changes locally 🧐

Download the sample project through this link and enter the following commands according to the CLI. Afterward, MacCatalyst should be added to the BuildCache as shown in the image below, and the cached sample project should build the MacCatalyst target.

  1. tuist fetch
  2. tuist cache warm --xcframeworks
  3. tuist generate --xcframeworks

Check the path ~/.tuist/Cache/BuildCache/

image

Contributor checklist ✅

  • The code has been linted using run ./fourier lint tuist --fix
  • The change is tested via unit testing or acceptance testing, or both
  • The title of the PR is formulated in a way that is usable as a changelog entry
  • In case the PR introduces changes that affect users, the documentation has been updated

Reviewer checklist ✅

  • The code architecture and patterns are consistent with the rest of the codebase
  • Reviewer has checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed, and the title is usable as a changelog entry

Copy link
Member

@fortmarek fortmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great PR 👏 It would be great if you could write an acceptance test here to test on the CI the maccatalyst project builds, so we don't have any further regressions here. You can read more about our acceptance tests in our docs.

Sources/TuistKit/Cache/CacheController.swift Outdated Show resolved Hide resolved
@devyhan
Copy link
Contributor Author

devyhan commented Mar 27, 2023

This is a great PR 👏 It would be great if you could write an acceptance test here to test on the CI the maccatalyst project builds, so we don't have any further regressions here. You can read more about our acceptance tests in our docs.

I haven't tried Acceptance Tests before, but I'll give it a shot based on the documentation and previous work.

@devyhan devyhan force-pushed the fix/dependencies.swift-not-generating-xcframework-with-catalyst branch from 0ff2df5 to cd79640 Compare March 27, 2023 09:40
@fortmarek fortmarek merged commit 4fdcf9d into tuist:main Mar 27, 2023
@fortmarek
Copy link
Member

Thanks a lot again @devyhan for the contribution 👏

@devyhan
Copy link
Contributor Author

devyhan commented Mar 28, 2023

@fortmarek @danyf90 , I learned a lot thanks to both of you. Thank you. 😁

@devyhan devyhan deleted the fix/dependencies.swift-not-generating-xcframework-with-catalyst branch March 28, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependencies.swift not generating xcframework with catalyst
3 participants