-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiplatform Phase 3 - Expose support in ProjectDescription
#5381
Commits on Nov 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8e25b91 - Browse repository at this point
Copy the full SHA 8e25b91View commit details -
Resolve all
GraphDependency
->GraphDependencyReference
via `depeβ¦β¦ndencyReference(to:from:) This allows a unified path for applying platform filters
Configuration menu - View commit details
-
Copy full SHA for 34daa55 - Browse repository at this point
Copy the full SHA 34daa55View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4c70da - Browse repository at this point
Copy the full SHA e4c70daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 518ec6f - Browse repository at this point
Copy the full SHA 518ec6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 63096b3 - Browse repository at this point
Copy the full SHA 63096b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 142585d - Browse repository at this point
Copy the full SHA 142585dView commit details -
Add logic to apply intermediate filters.
This covers two scenarios Apply platform filters to transitive dependencies if they exist in intermediate steps Given: A -> (.ios) B and B -> C Then: A -> (.ios) C Remove dependencies if intermediate filters result in a disjoint set Given: A -> (.ios) B and B -> (.macos) C Then: A -> C should have `nil` platform filters, which results it it being removed as a transitive dependency.
Configuration menu - View commit details
-
Copy full SHA for 83d757a - Browse repository at this point
Copy the full SHA 83d757aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e8f272d - Browse repository at this point
Copy the full SHA e8f272dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 902a770 - Browse repository at this point
Copy the full SHA 902a770View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19038a6 - Browse repository at this point
Copy the full SHA 19038a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97de5c8 - Browse repository at this point
Copy the full SHA 97de5c8View commit details -
Return
nil
instead of[]
in these two terminal casesThese remove the βalready visitedβ and βleaf dependencyβ branches from our traversal. Including `[]` causes our logic to incorrectly resolve to filters when these branches should be excluded from that calculation.
Configuration menu - View commit details
-
Copy full SHA for 1f16419 - Browse repository at this point
Copy the full SHA 1f16419View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e34346 - Browse repository at this point
Copy the full SHA 5e34346View commit details -
This changes things so that `[]` no longer represents a filter that applies to all. We will convert from `.all` to `[]` when we apply so that the Xcodeproj value is accurate, but within Tuist logic we need to distinguish between being applied to all platforms and none and unset.
Configuration menu - View commit details
-
Copy full SHA for 8ffc653 - Browse repository at this point
Copy the full SHA 8ffc653View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d0a6f9 - Browse repository at this point
Copy the full SHA 8d0a6f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0dee9c - Browse repository at this point
Copy the full SHA b0dee9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 66037e0 - Browse repository at this point
Copy the full SHA 66037e0View commit details
Commits on Nov 17, 2023
-
Refactor
dependencyReference(to:from:)
to be source of truth for maβ¦β¦pping Only call `platformFilters(from:to:)` within this method to reduce chance of divergent logic.
Configuration menu - View commit details
-
Copy full SHA for fccb9b6 - Browse repository at this point
Copy the full SHA fccb9b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for bcb639a - Browse repository at this point
Copy the full SHA bcb639aView commit details
Commits on Nov 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 02292d8 - Browse repository at this point
Copy the full SHA 02292d8View commit details -
Add logic to apply intermediate filters.
This covers two scenarios Apply platform filters to transitive dependencies if they exist in intermediate steps Given: A -> (.ios) B and B -> C Then: A -> (.ios) C Remove dependencies if intermediate filters result in a disjoint set Given: A -> (.ios) B and B -> (.macos) C Then: A -> C should have `nil` platform filters, which results it it being removed as a transitive dependency.
Configuration menu - View commit details
-
Copy full SHA for a10c5a1 - Browse repository at this point
Copy the full SHA a10c5a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f19aa8 - Browse repository at this point
Copy the full SHA 6f19aa8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 081f81f - Browse repository at this point
Copy the full SHA 081f81fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 90326ad - Browse repository at this point
Copy the full SHA 90326adView commit details -
Configuration menu - View commit details
-
Copy full SHA for c4a1e9e - Browse repository at this point
Copy the full SHA c4a1e9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 28d539a - Browse repository at this point
Copy the full SHA 28d539aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ebad21c - Browse repository at this point
Copy the full SHA ebad21cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bca818 - Browse repository at this point
Copy the full SHA 0bca818View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fe4e9e - Browse repository at this point
Copy the full SHA 8fe4e9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc4c302 - Browse repository at this point
Copy the full SHA cc4c302View commit details -
Configuration menu - View commit details
-
Copy full SHA for e870f75 - Browse repository at this point
Copy the full SHA e870f75View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6090a70 - Browse repository at this point
Copy the full SHA 6090a70View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fa0794 - Browse repository at this point
Copy the full SHA 9fa0794View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc3f592 - Browse repository at this point
Copy the full SHA dc3f592View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0cae51d - Browse repository at this point
Copy the full SHA 0cae51dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b82d6eb - Browse repository at this point
Copy the full SHA b82d6ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 161bb39 - Browse repository at this point
Copy the full SHA 161bb39View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7223a33 - Browse repository at this point
Copy the full SHA 7223a33View commit details -
Configuration menu - View commit details
-
Copy full SHA for d874718 - Browse repository at this point
Copy the full SHA d874718View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5b095c - Browse repository at this point
Copy the full SHA a5b095cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c00cd98 - Browse repository at this point
Copy the full SHA c00cd98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 842eb48 - Browse repository at this point
Copy the full SHA 842eb48View commit details -
Update
directStaticDependencies
to use `dependencyReference(to: froβ¦β¦m:)` to resolve filters
Configuration menu - View commit details
-
Copy full SHA for baed57a - Browse repository at this point
Copy the full SHA baed57aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8779722 - Browse repository at this point
Copy the full SHA 8779722View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5372d5 - Browse repository at this point
Copy the full SHA f5372d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 170a041 - Browse repository at this point
Copy the full SHA 170a041View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3883901 - Browse repository at this point
Copy the full SHA 3883901View commit details -
Configuration menu - View commit details
-
Copy full SHA for f16713f - Browse repository at this point
Copy the full SHA f16713fView commit details -
Configuration menu - View commit details
-
Copy full SHA for dc7abcc - Browse repository at this point
Copy the full SHA dc7abccView commit details -
Configuration menu - View commit details
-
Copy full SHA for e50be1c - Browse repository at this point
Copy the full SHA e50be1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 46c653f - Browse repository at this point
Copy the full SHA 46c653fView commit details -
Skip dependencies that are targeting unsupported platforms
This will filter out windows, linux, and other platforms when a dependency is exclusively conditional on them.
Configuration menu - View commit details
-
Copy full SHA for f7f6339 - Browse repository at this point
Copy the full SHA f7f6339View commit details -
Configuration menu - View commit details
-
Copy full SHA for d4de36d - Browse repository at this point
Copy the full SHA d4de36dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 671bff1 - Browse repository at this point
Copy the full SHA 671bff1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a4192f - Browse repository at this point
Copy the full SHA 2a4192fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 298d917 - Browse repository at this point
Copy the full SHA 298d917View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b3a04f - Browse repository at this point
Copy the full SHA 7b3a04fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a234c7 - Browse repository at this point
Copy the full SHA 5a234c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f3dc7ee - Browse repository at this point
Copy the full SHA f3dc7eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2238b7a - Browse repository at this point
Copy the full SHA 2238b7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c16654 - Browse repository at this point
Copy the full SHA 0c16654View commit details
Commits on Nov 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 71f625f - Browse repository at this point
Copy the full SHA 71f625fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7890331 - Browse repository at this point
Copy the full SHA 7890331View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68158ec - Browse repository at this point
Copy the full SHA 68158ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for b0840d7 - Browse repository at this point
Copy the full SHA b0840d7View commit details