Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generation not including macros from XCFrameworks #5801

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Conversation

pepicrft
Copy link
Contributor

Short description πŸ“

A bug in a logic recently introduced to return all the plugin executables for Swift Macros, causes the targets to miss the logic executable Swift flags for pre-compiled Swift Macros in XCFrameworks

Contributor checklist βœ…

  • The code has been linted using run mise run lint:fix
  • The change is tested via unit testing or acceptance testing, or both
  • The title of the PR is formulated in a way that is usable as a changelog entry
  • In case the PR introduces changes that affect users, the documentation has been updated

Reviewer checklist βœ…

  • The code architecture and patterns are consistent with the rest of the codebase
  • Reviewer has checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed, and the title is usable as a changelog entry

@pepicrft pepicrft added the changelog:fixed PR will be listed in the Fixed section of CHANGELOG label Jan 15, 2024
@pepicrft pepicrft requested a review from a team January 15, 2024 16:44
@pepicrft pepicrft self-assigned this Jan 15, 2024
@pepicrft pepicrft requested review from waltflanagan, kwridan and fortmarek and removed request for a team January 15, 2024 16:45
@pepicrft pepicrft merged commit 85fb761 into main Jan 15, 2024
7 of 9 checks passed
@pepicrft pepicrft deleted the fix-bug-plugins branch January 15, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:fixed PR will be listed in the Fixed section of CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants