Improve performance of resolving manifest file paths

[anlaital-oura]

Short description 📝

Running tuist edit in a large git repository is quite slow at the moment. Running Time Profiler indicates that globing is the root cause of the slowness as it globs the entire repository. This is despite .tuistignore being present, as exclusion is done only after globing.

These changes reduce the time it takes to run tuist edit in our large repository from 31s to 3s 1.5s 0.27s in release mode (M2 Max). Related discussion on Tuist Slack.

I tried running mise run tuist:test but it fails acceptance tests even on a clean checkout. Could you advise on how tests should be run locally? I don't know if it's because of Tuist 4 changes, but a lot of the documentation seems a bit outdated on this.

Before:

After:

How to test the changes locally 🧐

Run tuist scheme with edit argument against a custom working directory that is a large git repository.

Contributor checklist ✅

• The code has been linted using run mise run lint:fix
• The change is tested via unit testing or acceptance testing, or both
• The title of the PR is formulated in a way that is usable as a changelog entry
• In case the PR introduces changes that affect users, the documentation has been updated

Reviewer checklist ✅

• The code architecture and patterns are consistent with the rest of the codebase
• Reviewer has checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed, and the title is usable as a changelog entry

[fortmarek]

I tried running mise run tuist:test but it fails acceptance tests even on a clean checkout. Could you advise on how tests should be run locally? I don't know if it's because of Tuist 4 changes, but a lot of the documentation seems a bit outdated on this.

Yeah, currently, you need to run the acceptance tests using one of the acceptance tests scheme TuistAcceptanceTests, TuistTestAcceptanceTests, etc. The Tuist-Workspace scheme currently doesn't have the necessary env variables. This is missing in the docs right now, we'll make sure to add it soon 🙏

[anlaital-oura]

I will convert this to draft until I have time to fix the acceptance test issues now that I know how to run them locally.

[anlaital-oura]

Acceptance tests now pass locally with the exception of test_ios_app_with_transitive_framework() failing that also fails with clean main. I had to make the implementation just ever-so-slightly more complex, but hopefully now it supports all use cases. Let me know if some special testing is needed for this outside of automated tests and running this against our own project!

[danieleformichelli]

nit: you can use a guard and continue to reduce intentation

[anlaital-oura]

Done.

[fortmarek]

This is an amazing improvement 👏

[pepicrft]

just wow. Thanks a lot for this @anlaital-oura

[pepicrft]

@all-contributors add @anlaital-oura for code

[allcontributors]

@pepicrft

I've put up a pull request to add @anlaital-oura! 🎉