Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration of AppCenter #5935

Merged
merged 5 commits into from Feb 17, 2024
Merged

Fix integration of AppCenter #5935

merged 5 commits into from Feb 17, 2024

Conversation

fortmarek
Copy link
Member

Resolves #4024

Short description πŸ“

I added the umbrella header as the public header in Xcode, but we should rely on header search paths only. With the umbrella header set as public, the PLCrashReporter dependency does not build because the imports in the internal header files that try to use the module import instead of the filename import:

#if __has_include(<CrashReporter/CrashReporter.h>) // this should be false when compiling the `PLCrashReporter` module
#import <CrashReporter/CrashReporter.h>
#import <CrashReporter/PLCrashReporter.h>
#else // These are the imports that we want to use
#import "CrashReporter.h"
#import "PLCrashReporter.h"
#endif

How to test the changes locally 🧐

You should be able to run and build the app_with_spm_dependencies fixture

Contributor checklist βœ…

  • The code has been linted using run mise run lint:fix
  • The change is tested via unit testing or acceptance testing, or both
  • The title of the PR is formulated in a way that is usable as a changelog entry
  • In case the PR introduces changes that affect users, the documentation has been updated

Reviewer checklist βœ…

  • The code architecture and patterns are consistent with the rest of the codebase
  • Reviewer has checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed, and the title is usable as a changelog entry

@fortmarek fortmarek added the changelog:fixed PR will be listed in the Fixed section of CHANGELOG label Feb 15, 2024
@fortmarek fortmarek merged commit d5f3a18 into main Feb 17, 2024
8 checks passed
@fortmarek fortmarek deleted the fix/appcenter branch February 17, 2024 11:06
@mikeger
Copy link

mikeger commented Feb 17, 2024

Thanks for fixing AppCenter integration πŸ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:fixed PR will be listed in the Fixed section of CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dependencies.swift] Issues depending on AppCenter SDK
3 participants