Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generation of SPM packages when some resources are missing #6027

Merged
merged 2 commits into from Mar 4, 2024

Conversation

fortmarek
Copy link
Member

@fortmarek fortmarek commented Mar 4, 2024

Resolves #6019

Short description πŸ“

We skip adding globs where the base folder doesn't exist at all for external dependencies as we shouldn't be stricter than SPM.

How to test the changes locally 🧐

You should be able to generate and build the app_with_spm_dependencies project

Contributor checklist βœ…

  • The code has been linted using run mise run lint:fix
  • The change is tested via unit testing or acceptance testing, or both
  • The title of the PR is formulated in a way that is usable as a changelog entry
  • In case the PR introduces changes that affect users, the documentation has been updated

Reviewer checklist βœ…

  • The code architecture and patterns are consistent with the rest of the codebase
  • Reviewer has checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed, and the title is usable as a changelog entry

@fortmarek fortmarek added the changelog:fixed PR will be listed in the Fixed section of CHANGELOG label Mar 4, 2024
@fortmarek fortmarek marked this pull request as ready for review March 4, 2024 18:26
@fortmarek fortmarek merged commit a6a9626 into main Mar 4, 2024
8 checks passed
@fortmarek fortmarek deleted the fix/missing-resources branch March 4, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:fixed PR will be listed in the Fixed section of CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tuist is a bit strict about SPM dependencies with invalid Resources folder
2 participants