Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting visionOS deployment target for appleVisionWithiPadDesign #6033

Merged
merged 3 commits into from Mar 7, 2024

Conversation

freak4pc
Copy link
Sponsor Contributor

@freak4pc freak4pc commented Mar 5, 2024

Short description πŸ“

I reported this issue on Slack and discussed with @waltflanagan, when setting appleVisionWithiPadDesign - you should be able to set a visionOS-specific deployment target.

Otherwise, Xcode defaults to the latest one, which could be 1.1 (even if you want 1.0, for example).

How to test the changes locally 🧐

  • Create a project that has iPhone, iPad and appleVisionWithiPadDesign Destinations.
  • Set a multiplatform deployment target for iOS & visionOS.
  • Before this fix, this yields this error:

image

I've added tests to cover these areas.

Contributor checklist βœ…

  • The code has been linted using run mise run lint:fix
  • The change is tested via unit testing or acceptance testing, or both
  • The title of the PR is formulated in a way that is usable as a changelog entry
  • In case the PR introduces changes that affect users, the documentation has been updated

Reviewer checklist βœ…

  • The code architecture and patterns are consistent with the rest of the codebase
  • Reviewer has checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed, and the title is usable as a changelog entry

@freak4pc
Copy link
Sponsor Contributor Author

freak4pc commented Mar 6, 2024

@waltflanagan Check it out when you have a moment. Thanks!

@freak4pc
Copy link
Sponsor Contributor Author

freak4pc commented Mar 6, 2024

Uhm, the tests are passing locally and I can't enter Codemagic to see what it failed on. Isn't it an OSS-centric CI that everyone can see the build failures?

Any thoughts?

@pepicrft
Copy link
Contributor

pepicrft commented Mar 6, 2024

Uhm, the tests are passing locally and I can't enter Codemagic to see what it failed on. Isn't it an OSS-centric CI that everyone can see the build failures?
Any thoughts?

I'm looking into the Codemagic authorization issue. Regarding the failing builds, it's also a known issue with the Tuist Cloud API. We are looking into it. To prevent it from blocking the merge of this PR, I'll run the workflows locally before merging once @waltflanagan confirms the changes are fine.

@danieleformichelli danieleformichelli merged commit ace3fc0 into tuist:main Mar 7, 2024
8 checks passed
@freak4pc freak4pc deleted the vision-versioning branch March 8, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants