Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generate with Workspace.swift #6039

Merged
merged 1 commit into from Mar 6, 2024
Merged

Fix generate with Workspace.swift #6039

merged 1 commit into from Mar 6, 2024

Conversation

fortmarek
Copy link
Member

@fortmarek fortmarek commented Mar 6, 2024

Resolves #6038

Short description πŸ“

If you have a Workspace.swift with the projects: ["./**"], we would match also packages in the .build/checkouts and the Package.swift in the Tuist directory since we added direct support for SPM packages.

How to test the changes locally 🧐

Run generate on the project in the attached issue. You should no longer get a crash.

Contributor checklist βœ…

  • The code has been linted using run mise run lint:fix
  • The change is tested via unit testing or acceptance testing, or both
  • The title of the PR is formulated in a way that is usable as a changelog entry
  • In case the PR introduces changes that affect users, the documentation has been updated

Reviewer checklist βœ…

  • The code architecture and patterns are consistent with the rest of the codebase
  • Reviewer has checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed, and the title is usable as a changelog entry

@fortmarek fortmarek requested a review from pepicrft March 6, 2024 12:42
@fortmarek fortmarek marked this pull request as ready for review March 6, 2024 12:42
@pepicrft pepicrft added the changelog:fixed PR will be listed in the Fixed section of CHANGELOG label Mar 6, 2024
@fortmarek fortmarek merged commit d7bd6f1 into main Mar 6, 2024
8 checks passed
@fortmarek fortmarek deleted the fix/package-workspace branch March 6, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:fixed PR will be listed in the Fixed section of CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tuist cache and generate are broken
2 participants