Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiling libraries with umbrella headers that have a dash #6042

Merged
merged 1 commit into from Mar 7, 2024

Conversation

fortmarek
Copy link
Member

Resolves #6037

Short description πŸ“

The swift-markdown-ui library has two headers in the public headers path:

  • cfmark-gfm.h
  • and cfmark_gfm.h

When comparing with the generated module map by SPM, it turns out we should only use the header that has the sanitized version (dashes replaced with underscores)

How to test the changes locally 🧐

The app_with_spm_dependencies fixture that now has the swift-markdown-ui as a dependency should build.

Contributor checklist βœ…

  • The code has been linted using run mise run lint:fix
  • The change is tested via unit testing or acceptance testing, or both
  • The title of the PR is formulated in a way that is usable as a changelog entry
  • In case the PR introduces changes that affect users, the documentation has been updated

Reviewer checklist βœ…

  • The code architecture and patterns are consistent with the rest of the codebase
  • Reviewer has checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed, and the title is usable as a changelog entry

@fortmarek fortmarek added the changelog:fixed PR will be listed in the Fixed section of CHANGELOG label Mar 6, 2024
@danieleformichelli danieleformichelli merged commit fc18623 into main Mar 7, 2024
8 checks passed
@danieleformichelli danieleformichelli deleted the fix/sanitize-header-path branch March 7, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:fixed PR will be listed in the Fixed section of CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cant build project if MarkdownUI is imported
3 participants