Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration of swift-testing #6062

Merged
merged 4 commits into from Mar 11, 2024
Merged

Fix integration of swift-testing #6062

merged 4 commits into from Mar 11, 2024

Conversation

fortmarek
Copy link
Member

@fortmarek fortmarek commented Mar 10, 2024

Resolves #5795

Short description πŸ“

This PR fixes the integration of swift-testing. There were two issues:

  • in the hardcoded mapping for test targets, we were missing the Testing framework. Long-term, we should still find an automatic way to derive whether we should add the ENABLE_TESTING_SEARCH_PATHS or not.
  • allSwiftMacroTargets method in the GraphTraverser wouldn't actually return a direct macro dependency.
  • The copy macro build phase must be before the compile sources phase for targets that directly depend on a macro

How to test the changes locally 🧐

You should be able to test AppKit in the app_with_spm_dependencies fixture.

Contributor checklist βœ…

  • The code has been linted using run mise run lint:fix
  • The change is tested via unit testing or acceptance testing, or both
  • The title of the PR is formulated in a way that is usable as a changelog entry
  • In case the PR introduces changes that affect users, the documentation has been updated

Reviewer checklist βœ…

  • The code architecture and patterns are consistent with the rest of the codebase
  • Reviewer has checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed, and the title is usable as a changelog entry

@fortmarek fortmarek marked this pull request as ready for review March 10, 2024 11:14
Co-authored-by: Shai Mishali <freak4pc@gmail.com>
@danieleformichelli danieleformichelli enabled auto-merge (squash) March 10, 2024 18:39
@fortmarek fortmarek added the changelog:fixed PR will be listed in the Fixed section of CHANGELOG label Mar 11, 2024
@fortmarek fortmarek disabled auto-merge March 11, 2024 14:35
@fortmarek fortmarek merged commit 87cdf10 into main Mar 11, 2024
8 checks passed
@fortmarek fortmarek deleted the fix/swift-testing branch March 11, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:fixed PR will be listed in the Fixed section of CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support swift-testing
4 participants