Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the look up of the templates directory in a Homebrew installation #6095

Merged
merged 2 commits into from Mar 19, 2024

Conversation

pepicrft
Copy link
Contributor

Resolves #5763

Short description πŸ“

The directory structure convention that we had in our logic was wrong. It should be the path share/Templates, relative to the root directory of the formula.

image

How to test the changes locally 🧐

It's a bit tricky to test locally but it requires reproducing the Homebrew directory structure.

Contributor checklist βœ…

  • The code has been linted using run mise run lint:fix
  • The change is tested via unit testing or acceptance testing, or both
  • The title of the PR is formulated in a way that is usable as a changelog entry
  • In case the PR introduces changes that affect users, the documentation has been updated

Reviewer checklist βœ…

  • The code architecture and patterns are consistent with the rest of the codebase
  • Reviewer has checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed, and the title is usable as a changelog entry

@pepicrft pepicrft added the changelog:fixed PR will be listed in the Fixed section of CHANGELOG label Mar 18, 2024
@pepicrft pepicrft self-assigned this Mar 18, 2024
@pepicrft pepicrft merged commit 3092695 into main Mar 19, 2024
8 checks passed
@pepicrft pepicrft deleted the fix-templates-directory branch March 19, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:fixed PR will be listed in the Fixed section of CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brew install-ed tuist has no scaffolds
2 participants