Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SPM integration of the latest version of swift-testing #6121

Merged
merged 6 commits into from Mar 27, 2024

Conversation

fortmarek
Copy link
Member

Short description πŸ“

Fixes latest version of swift-testing. The latest version due to the addition of these Swift flags that we were not properly escaping and they were treated as separate options.

I removed SwiftLint from the app_with_spm_dependencies fixture since we were not really using it and since swift-lint has an exact dependency on swift-syntax that's different from swift-testing, it's currently impossible to have both libraries in your Package.swift (if you want to have the latest version of swift-testing and don't want to fork SwiftLint)

How to test the changes locally 🧐

Testing AppKit in app_with_spm_dependencies should work.

Contributor checklist βœ…

  • The code has been linted using run mise run lint:fix
  • The change is tested via unit testing or acceptance testing, or both
  • The title of the PR is formulated in a way that is usable as a changelog entry
  • In case the PR introduces changes that affect users, the documentation has been updated

Reviewer checklist βœ…

  • The code architecture and patterns are consistent with the rest of the codebase
  • Reviewer has checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed, and the title is usable as a changelog entry

@fortmarek fortmarek added the changelog:fixed PR will be listed in the Fixed section of CHANGELOG label Mar 26, 2024
@fortmarek fortmarek requested a review from pepicrft March 26, 2024 08:59
@fortmarek fortmarek merged commit 97d9352 into main Mar 27, 2024
8 checks passed
@fortmarek fortmarek deleted the fix/swift-testing branch March 27, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:fixed PR will be listed in the Fixed section of CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants