Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running Tuist.graph() in a Tuist task #6129

Merged
merged 3 commits into from Mar 28, 2024
Merged

Fix running Tuist.graph() in a Tuist task #6129

merged 3 commits into from Mar 28, 2024

Conversation

fortmarek
Copy link
Member

@fortmarek fortmarek commented Mar 27, 2024

Short description πŸ“

This PR should fix the current tasks that could not find the tuist executable. The primary issue was that we were not passing the tuist executable properly. We want to move away from the model where tuist triggers the tuist task which triggers tuist again. Instead, we want the tuist task to be a regular Swift CLI that just uses the ProjectAutomation framework to be able to easily decode the graph to a Swift model from the tuist graph --format json invocation.

I hope to prepare a long-term proposal for tuist tasks future soon as the current setup has a lot of indirection and unnecessary maintenance costs for us.

How to test the changes locally 🧐

You can test the functionality by running swift run --package-path InspectGraph inspect-graph inside the app_with_plugins fixture.

Contributor checklist βœ…

  • The code has been linted using run mise run lint:fix
  • The change is tested via unit testing or acceptance testing, or both
  • The title of the PR is formulated in a way that is usable as a changelog entry
  • In case the PR introduces changes that affect users, the documentation has been updated

Reviewer checklist βœ…

  • The code architecture and patterns are consistent with the rest of the codebase
  • Reviewer has checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed, and the title is usable as a changelog entry

@fortmarek fortmarek requested a review from pepicrft March 27, 2024 14:55
@fortmarek fortmarek added the changelog:fixed PR will be listed in the Fixed section of CHANGELOG label Mar 27, 2024
@fortmarek fortmarek merged commit 78ca830 into main Mar 28, 2024
8 checks passed
@fortmarek fortmarek deleted the fix/tuist-tasks branch March 28, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:fixed PR will be listed in the Fixed section of CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants