Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resources filename mismatch when a dependency has a + #6151

Merged
merged 1 commit into from Apr 5, 2024

Conversation

fortmarek
Copy link
Member

Resolves #6099

Short description πŸ“

The ResourcesProjectMapper would have a mismatch between referencing the bundle accessor file and the actual filename when the dependency had a +. To fix this, we no longer run camelized for the generated filename (I don't see why we'd need to do that).

How to test the changes locally 🧐

Integrating FirebaseAppMessaging-Beta via Tuist/Package.swift should work.

Contributor checklist βœ…

  • The code has been linted using run mise run lint:fix
  • The change is tested via unit testing or acceptance testing, or both
  • The title of the PR is formulated in a way that is usable as a changelog entry
  • In case the PR introduces changes that affect users, the documentation has been updated

Reviewer checklist βœ…

  • The code architecture and patterns are consistent with the rest of the codebase
  • Reviewer has checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed, and the title is usable as a changelog entry

@fortmarek fortmarek added the changelog:fixed PR will be listed in the Fixed section of CHANGELOG label Apr 4, 2024
@fortmarek fortmarek merged commit c84f3e0 into main Apr 5, 2024
8 checks passed
@fortmarek fortmarek deleted the fix/firebase-messaging branch April 5, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:fixed PR will be listed in the Fixed section of CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SPM dependency with a dash failed to compile
2 participants