New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing external target settings with config conditions #6170
Conversation
} | ||
|
||
func settingsForPlatforms(_ platforms: [PackageInfo.Platform]) throws -> TuistGraph.SettingsDictionary { | ||
var resolvedSettings = try settingsDictionaryForPlatform(nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it mean to get a settings dictionary for a platform nil
? I'd iterate on the implementation to make the code more readable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's nil, it doesn't take a platform in the account. It was here before, but sure, let me refactor it 👍
I confirmed that it was processed automatically. via |
@topkim993 The easiest way is to usually run tuist via Xcode as described here |
@fortmarek @pepicrft Hello, Is there any new development here? I hope the next version will contain this fix, it's really important to us. |
Resolves #6157
Short description 📝
The issue with the Lookin dependency is that it has a
.define
setting with a config condition: https://github.com/QMUI/LookinServer/blob/develop/Package.swift#L53While we decode that condition, we'd never actually use that setting.
The solution is to add the
.define
to the specified configuration settings.How to test the changes locally 🧐
app_with_spm_dependencies
SPM_LOOKIN_SERVER_ENABLED
is defined for Debug configurationContributor checklist ✅
mise run lint:fix
Reviewer checklist ✅
changelog:added
,changelog:fixed
, orchangelog:changed
, and the title is usable as a changelog entry