Adds codeCoverageTargets to TestAction #619
Conversation
abbasmousavi
force-pushed
the
codeCoverageTargets
branch
from
13ae259
to
794a7eb
Compare
| @@ -161,6 +161,18 @@ final class SchemesGenerator: SchemesGenerating { | |||
| var testables: [XCScheme.TestableReference] = [] | |||
| var preActions: [XCScheme.ExecutionAction] = [] | |||
| var postActions: [XCScheme.ExecutionAction] = [] | |||
| var codeCoverageTargets: [XCScheme.BuildableReference] = [] | |||
|
|
|||
| testAction.codeCoverageTargets.forEach { name in | |||
There was a problem hiding this comment.
I'd add a unit test to make sure that the buildable references are added to the scheme.
| @@ -161,6 +161,18 @@ final class SchemesGenerator: SchemesGenerating { | |||
| var testables: [XCScheme.TestableReference] = [] | |||
| var preActions: [XCScheme.ExecutionAction] = [] | |||
| var postActions: [XCScheme.ExecutionAction] = [] | |||
| var codeCoverageTargets: [XCScheme.BuildableReference] = [] | |||
|
|
|||
| testAction.codeCoverageTargets.forEach { name in | |||
There was a problem hiding this comment.
What about extracting this into a method:
func testCoverageTargetReferences(...) -> [XCScheme.BuildableReference] {
}
There was a problem hiding this comment.
Hey @abbasmousavi, this PR is looking great. Besides the comments that I added, I'd add a lint check to make sure that the targets that have test coverage enabled exist in the project. This will be your friend for that.
abbasmousavi
force-pushed
the
codeCoverageTargets
branch
from
06d4664
to
87863fb
Compare
|
Hey @pepibumur, thanks for comments and hints. I have added linting check and a test. |
Thanks for adding those. There are only 2 minor things missing, updating the documentation, which is in the After that we are good to merge this PR. |
@pepibumur, The PR already contains changes to documents and changelog https://github.com/tuist/tuist/blob/1f5df61c5b24b8ae247ced29dbd25f517c7d7a26/CHANGELOG.md |
|
Sorry, I missed those. All good then @abbasmousavi. I'm mergint the PR... 🚀 |
Resolves #618
Short description 📝
Adds codeCoverageTargets to TestAction
Solution 📦
This property is already implemented in XcodeProj. We only need to assign values to related properties.
Implementation 👩💻👨💻
It adds
codeCoverageTargetsproperty to theTestActionmodel in manifest and uses it to populatecodeCoverageTargetsandonlyGenerateCoverageForSpecifiedTargetsinXCScheme.TestAction