Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration of Cuckoo #6195

Merged

Conversation

danibachar
Copy link
Collaborator

Short description πŸ“

Cuckoo is using XCTest APIs, as such it needs the XCTest framework to be available.
Adding it to the hard coded list, should solve that issue.

How to test the changes locally 🧐

You can reproduce the problem in this example repo
We have updated the fixture app_with_spm_dependencies to include Cuckoo and import it, such that it should compile.

Contributor checklist βœ…

  • The code has been linted using run mise run lint:fix
  • The change is tested via unit testing or acceptance testing, or both
  • The title of the PR is formulated in a way that is usable as a changelog entry
  • In case the PR introduces changes that affect users, the documentation has been updated

Reviewer checklist βœ…

  • The code architecture and patterns are consistent with the rest of the codebase
  • Reviewer has checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed, and the title is usable as a changelog entry

To allow compilation of Cuckoo dependent targets, I have added Cuckoo into the hard coded list
@danibachar danibachar force-pushed the danibachar/cuckoo-search-path-update branch from 025e049 to fb0de5f Compare April 15, 2024 20:09
@danibachar danibachar changed the title Danibachar/cuckoo search path update Add Cuckoo to tests search path list Apr 15, 2024
@fortmarek fortmarek changed the title Add Cuckoo to tests search path list Fix integration of Cuckoo Apr 16, 2024
@fortmarek fortmarek added the changelog:fixed PR will be listed in the Fixed section of CHANGELOG label Apr 16, 2024
@fortmarek fortmarek merged commit 77acd40 into tuist:main Apr 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:fixed PR will be listed in the Fixed section of CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants